Skip to content

Conversation

CYFS3
Copy link
Contributor

@CYFS3 CYFS3 commented Jan 18, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

#9886

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP BSP: Renesas BSP related with Renesas BSP: GD32 BSP related with GD32 BSP: Infineon BSP related with Infineon BSP: AT32 BSP related with AT32 BSP: WCH BSP related with WCH labels Jan 18, 2025
@CYFS3
Copy link
Contributor Author

CYFS3 commented Jan 18, 2025

@kurisaW

@supperthomas
Copy link
Member

supperthomas commented Jan 18, 2025

                    if BSP_USING_I2C1_SW
                            config BSP_I2C1_SLC_PIN
                            int "i2c1 slc pin number"
                            range 0 51
                            default 24

                            config BSP_I2C1_SDA_PIN
                            int "i2c1 sda pin number"
                            range 0 51
                            default 25

kconfig这里的信息你要保存下来的,后面人再用就不好用了,
可以放到ci.yml里面加上以下信息。

componet.soft_i2c:
 kconfig:
   - CONFIG_RT_USING_SOFT_I2C1=y
   - CONFIG_RT_SOFT_I2C0_SCL_PIN=24 
   - CONFIG_RT_SOFT_I2C0_SDA_PIN=25 

@CYFS3 CYFS3 marked this pull request as draft January 18, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP: AT32 BSP related with AT32 BSP: GD32 BSP related with GD32 BSP: Infineon BSP related with Infineon BSP: Renesas BSP related with Renesas BSP: STM32 BSP related with ST/STM32 BSP: WCH BSP related with WCH BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants